From bf1378bf96c20b667f1b35b4265f8ae0017c40f5 Mon Sep 17 00:00:00 2001
From: Sean Sube <seansube@gmail.com>
Date: Sun, 5 Feb 2023 08:50:26 -0600
Subject: [PATCH] fix(api): log stacktrace from job errors

---
 api/onnx_web/chain/correct_codeformer.py |  8 +-------
 api/onnx_web/device_pool.py              |  3 ++-
 common/pipelines/codeformer.json         | 16 ++++++++++++++++
 3 files changed, 19 insertions(+), 8 deletions(-)
 create mode 100644 common/pipelines/codeformer.json

diff --git a/api/onnx_web/chain/correct_codeformer.py b/api/onnx_web/chain/correct_codeformer.py
index c5dfd7ce..f06cfaaa 100644
--- a/api/onnx_web/chain/correct_codeformer.py
+++ b/api/onnx_web/chain/correct_codeformer.py
@@ -24,12 +24,6 @@ def correct_codeformer(
     source_image: Image.Image,
     **kwargs,
 ) -> Image.Image:
-    pipe = CodeFormer(
-        dim_embd=512,
-        codebook_size=1024,
-        n_head=8,
-        n_layers=9,
-        connect_list=["32", "64", "128", "256"],
-    ).to(device)
+    pipe = CodeFormer().to(device)
 
     return pipe(source_image)
diff --git a/api/onnx_web/device_pool.py b/api/onnx_web/device_pool.py
index a2ef1c0e..907d4b70 100644
--- a/api/onnx_web/device_pool.py
+++ b/api/onnx_web/device_pool.py
@@ -2,6 +2,7 @@ from collections import Counter
 from concurrent.futures import Future, ProcessPoolExecutor, ThreadPoolExecutor
 from logging import getLogger
 from multiprocessing import Value
+from traceback import format_exception
 from typing import Any, Callable, List, Optional, Tuple, Union
 
 from .params import DeviceParams
@@ -191,7 +192,7 @@ class DevicePoolExecutor:
                 f.result()
                 logger.info("job %s finished successfully", key)
             except Exception as err:
-                logger.warn("job %s failed with an error: %s", key, err)
+                logger.warn("job %s failed with an error: %s", key, format_exception(type(err), err, err.__traceback__))
 
         future.add_done_callback(job_done)
 
diff --git a/common/pipelines/codeformer.json b/common/pipelines/codeformer.json
new file mode 100644
index 00000000..1d026a56
--- /dev/null
+++ b/common/pipelines/codeformer.json
@@ -0,0 +1,16 @@
+{
+  "stages": [
+    {
+      "name": "faces",
+      "type": "correct-codeformer",
+      "params": {}
+    },
+    {
+      "name": "save-local",
+      "type": "persist-disk",
+      "params": {
+        "tile_size": "hd8k"
+      }
+    }
+  ]
+}
\ No newline at end of file