From d2c7fa97e79267b4694556e0019c0abd63bd229a Mon Sep 17 00:00:00 2001
From: Sean Sube <seansube@gmail.com>
Date: Tue, 17 Jan 2023 17:51:25 -0600
Subject: [PATCH] fix(gui): remove unused strength param from upscale

---
 gui/src/client.ts                 |  1 -
 gui/src/components/Inpaint.tsx    |  1 +
 gui/src/components/MaskCanvas.tsx |  3 ++-
 gui/src/components/Upscale.tsx    | 14 --------------
 gui/src/state.ts                  |  2 --
 5 files changed, 3 insertions(+), 18 deletions(-)

diff --git a/gui/src/client.ts b/gui/src/client.ts
index 61d4a6c3..ea67c17a 100644
--- a/gui/src/client.ts
+++ b/gui/src/client.ts
@@ -78,7 +78,6 @@ export interface UpscaleParams {
 
 export interface UpscaleReqParams {
   source: Blob;
-  strength: number;
 }
 
 export interface ImageResponse {
diff --git a/gui/src/components/Inpaint.tsx b/gui/src/components/Inpaint.tsx
index 3cc20d26..ab84694e 100644
--- a/gui/src/components/Inpaint.tsx
+++ b/gui/src/components/Inpaint.tsx
@@ -108,6 +108,7 @@ export function Inpaint() {
         }}
       />
       <Stack direction='row' spacing={2}>
+        {/* TODO: numeric input for blend strength */}
         <QueryList
           id='masks'
           labels={MASK_LABELS}
diff --git a/gui/src/components/MaskCanvas.tsx b/gui/src/components/MaskCanvas.tsx
index 3668d767..9520a69d 100644
--- a/gui/src/components/MaskCanvas.tsx
+++ b/gui/src/components/MaskCanvas.tsx
@@ -231,7 +231,8 @@ export function MaskCanvas(props: MaskCanvasProps) {
       }}
     />
     <Typography variant='body1'>
-      Black pixels in the mask will stay the same, white pixels will be replaced with pixels from the noise source.
+      Black pixels in the mask will stay the same, white pixels will be replaced. The masked pixels will be blended
+      with the noise source before the diffusion model runs, giving it more variety to use.
     </Typography>
     <Stack direction='row' spacing={4}>
       <NumericField
diff --git a/gui/src/components/Upscale.tsx b/gui/src/components/Upscale.tsx
index b0f4bc89..ddb5f9c1 100644
--- a/gui/src/components/Upscale.tsx
+++ b/gui/src/components/Upscale.tsx
@@ -7,7 +7,6 @@ import { useStore } from 'zustand';
 import { IMAGE_FILTER } from '../config.js';
 import { ClientContext, ConfigContext, StateContext } from '../state.js';
 import { ImageInput } from './ImageInput.js';
-import { NumericField } from './NumericField.js';
 import { UpscaleControl } from './UpscaleControl.js';
 
 const { useContext } = React;
@@ -46,19 +45,6 @@ export function Upscale() {
           source: file,
         });
       }} />
-      <NumericField
-        decimal
-        label='Strength'
-        min={config.strength.min}
-        max={config.strength.max}
-        step={config.strength.step}
-        value={params.strength}
-        onChange={(value) => {
-          setSource({
-            strength: value,
-          });
-        }}
-      />
       <UpscaleControl config={config} />
       <Button onClick={() => upload.mutate()}>Generate</Button>
     </Stack>
diff --git a/gui/src/state.ts b/gui/src/state.ts
index 9fc42e06..a1ec8ff0 100644
--- a/gui/src/state.ts
+++ b/gui/src/state.ts
@@ -258,7 +258,6 @@ export function createStateSlices(base: ConfigParams) {
     },
     upscaleTab: {
       source: null,
-      strength: 1.0,
     },
     setUpscale(upscale) {
       set((prev) => ({
@@ -280,7 +279,6 @@ export function createStateSlices(base: ConfigParams) {
       set({
         upscaleTab: {
           source: null,
-          strength: 1.0,
         },
       });
     },