From 131c9bf530401accb12a3fa5827aeb85923d2798 Mon Sep 17 00:00:00 2001
From: ssube <seansube@gmail.com>
Date: Wed, 29 Jul 2020 08:22:32 -0500
Subject: [PATCH] lint: type naming for new rules

---
 config/eslint.json                   | 16 +++++++++++-----
 docs/api/js-utils.constructorname.md |  4 ++--
 docs/api/js-utils.getconstructor.md  |  4 ++--
 docs/api/js-utils.getmethods.md      |  4 ++--
 docs/api/js-utils.timeout.md         |  4 ++--
 src/Reflect.ts                       | 13 +++++++++----
 src/Signal.ts                        |  2 +-
 7 files changed, 29 insertions(+), 18 deletions(-)

diff --git a/config/eslint.json b/config/eslint.json
index 4d79504..e0ac66e 100644
--- a/config/eslint.json
+++ b/config/eslint.json
@@ -106,6 +106,15 @@
                 "leadingUnderscore": "forbid",
                 "trailingUnderscore": "forbid"
             },
+            {
+                "selector": "enumMember",
+                "format": [
+                    "camelCase",
+                    "UPPER_CASE"
+                ],
+                "leadingUnderscore": "forbid",
+                "trailingUnderscore": "forbid"
+            },
             {
                 "selector": "typeLike",
                 "format": [
@@ -120,10 +129,7 @@
                     "PascalCase"
                 ],
                 "leadingUnderscore": "forbid",
-                "trailingUnderscore": "forbid",
-                "prefix": [
-                    "I"
-                ]
+                "trailingUnderscore": "forbid"
             }
         ],
         "@typescript-eslint/no-empty-function": "error",
@@ -423,4 +429,4 @@
             }
         ]
     }
-}
\ No newline at end of file
+}
diff --git a/docs/api/js-utils.constructorname.md b/docs/api/js-utils.constructorname.md
index 2e3d9a5..8905b3a 100644
--- a/docs/api/js-utils.constructorname.md
+++ b/docs/api/js-utils.constructorname.md
@@ -9,14 +9,14 @@ Get the constructor name from an instance.
 <b>Signature:</b>
 
 ```typescript
-export declare function constructorName(val: object): string;
+export declare function constructorName(val: Reflectable): string;
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
-|  val | object |  |
+|  val | Reflectable |  |
 
 <b>Returns:</b>
 
diff --git a/docs/api/js-utils.getconstructor.md b/docs/api/js-utils.getconstructor.md
index f78eb8c..1f167e1 100644
--- a/docs/api/js-utils.getconstructor.md
+++ b/docs/api/js-utils.getconstructor.md
@@ -9,14 +9,14 @@ Get the constructor from an instance.
 <b>Signature:</b>
 
 ```typescript
-export declare function getConstructor(val: object): Function;
+export declare function getConstructor(val: Reflectable): Function;
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
-|  val | object |  |
+|  val | Reflectable |  |
 
 <b>Returns:</b>
 
diff --git a/docs/api/js-utils.getmethods.md b/docs/api/js-utils.getmethods.md
index 20a0d21..8a969ba 100644
--- a/docs/api/js-utils.getmethods.md
+++ b/docs/api/js-utils.getmethods.md
@@ -9,7 +9,7 @@ Get the methods from an instance and its prototypes.
 <b>Signature:</b>
 
 ```typescript
-export declare function getMethods<TValue extends object>(value: TValue): Set<Function>;
+export declare function getMethods<TValue extends Reflectable>(value: TValue): Set<Method<TValue>>;
 ```
 
 ## Parameters
@@ -20,5 +20,5 @@ export declare function getMethods<TValue extends object>(value: TValue): Set<Fu
 
 <b>Returns:</b>
 
-Set&lt;Function&gt;
+Set&lt;Method&lt;TValue&gt;&gt;
 
diff --git a/docs/api/js-utils.timeout.md b/docs/api/js-utils.timeout.md
index 23e6d37..8f2a00a 100644
--- a/docs/api/js-utils.timeout.md
+++ b/docs/api/js-utils.timeout.md
@@ -9,7 +9,7 @@ Reject after a set amount of time if the original promise has not yet resolved.
 <b>Signature:</b>
 
 ```typescript
-export declare function timeout<T>(ms: number, oper: Promise<T>): Promise<Optional<T>>;
+export declare function timeout<T>(ms: number, oper: Promise<T>): Promise<T>;
 ```
 
 ## Parameters
@@ -21,5 +21,5 @@ export declare function timeout<T>(ms: number, oper: Promise<T>): Promise<Option
 
 <b>Returns:</b>
 
-Promise&lt;[Optional](./js-utils.optional.md)<!-- -->&lt;T&gt;&gt;
+Promise&lt;T&gt;
 
diff --git a/src/Reflect.ts b/src/Reflect.ts
index a283632..237434b 100644
--- a/src/Reflect.ts
+++ b/src/Reflect.ts
@@ -2,12 +2,17 @@ import { isFunction } from 'lodash';
 
 import { doesExist, isNil } from './Maybe';
 
+/* eslint-disable-next-line @typescript-eslint/ban-types */
+type Reflectable = object;
+
+type Method<TClass> = (this: TClass, ...args: Array<unknown>) => unknown;
+
 /**
  * Get the constructor from an instance.
  *
  * @public
  */
-export function getConstructor(val: object) {
+export function getConstructor(val: Reflectable) {
   return val.constructor;
 }
 
@@ -16,8 +21,8 @@ export function getConstructor(val: object) {
  *
  * @public
  */
-export function getMethods<TValue extends object>(value: TValue): Set<Function> {
-  const methods = new Set<Function>();
+export function getMethods<TValue extends Reflectable>(value: TValue): Set<Method<TValue>> {
+  const methods = new Set<Method<TValue>>();
 
   for (const name of Object.getOwnPropertyNames(value)) {
     const desc = Object.getOwnPropertyDescriptor(value, name);
@@ -46,6 +51,6 @@ export function getMethods<TValue extends object>(value: TValue): Set<Function>
  *
  * @public
  */
-export function constructorName(val: object) {
+export function constructorName(val: Reflectable) {
   return getConstructor(Reflect.getPrototypeOf(val)).name;
 }
diff --git a/src/Signal.ts b/src/Signal.ts
index 35e0266..26ccfcc 100644
--- a/src/Signal.ts
+++ b/src/Signal.ts
@@ -3,7 +3,7 @@ export const SIGNAL_RESET: NodeJS.Signals = 'SIGINT';
 export const SIGNAL_STOP: NodeJS.Signals = 'SIGTERM';
 
 export function signal(...signals: Array<NodeJS.Signals>): Promise<NodeJS.Signals> {
-  return new Promise((res, _) => {
+  return new Promise((res, rej) => {
     function handler(fired: NodeJS.Signals) {
       for (const s of signals) {
         process.removeListener(s, handler);