lint: split rule visitor tests
This commit is contained in:
parent
4fef163e5b
commit
26eda4c6fe
|
|
@ -1,11 +1,8 @@
|
|||
import { expect } from 'chai';
|
||||
import { LogLevel, NullLogger } from 'noicejs';
|
||||
import { mock, spy, stub } from 'sinon';
|
||||
import { LogLevel } from 'noicejs';
|
||||
|
||||
import { createRuleSelector, createRuleSources, resolveRules } from '../../src/rule';
|
||||
import { RuleVisitor } from '../../src/rule/RuleVisitor';
|
||||
import { SchemaRule } from '../../src/rule/SchemaRule';
|
||||
import { VisitorContext } from '../../src/visitor/VisitorContext';
|
||||
import { describeLeaks, itLeaks } from '../helpers/async';
|
||||
|
||||
const TEST_RULES = [new SchemaRule({
|
||||
|
|
@ -102,172 +99,6 @@ describeLeaks('rule resolver', async () => {
|
|||
});
|
||||
});
|
||||
|
||||
describeLeaks('rule visitor', async () => {
|
||||
itLeaks('should only call visit for selected items', async () => {
|
||||
const ctx = new VisitorContext({
|
||||
logger: NullLogger.global,
|
||||
schemaOptions: {
|
||||
coerce: false,
|
||||
defaults: false,
|
||||
mutate: false,
|
||||
},
|
||||
});
|
||||
const data = {};
|
||||
const rule = new SchemaRule({
|
||||
check: {},
|
||||
desc: '',
|
||||
level: LogLevel.Info,
|
||||
name: 'foo',
|
||||
select: '$',
|
||||
tags: [],
|
||||
});
|
||||
|
||||
const mockRule = mock(rule);
|
||||
mockRule.expects('visit').never();
|
||||
|
||||
const pickStub = mockRule.expects('pick').once().withArgs(ctx, data);
|
||||
pickStub.onFirstCall().returns(Promise.resolve([]));
|
||||
pickStub.throws();
|
||||
|
||||
const visitor = new RuleVisitor({
|
||||
rules: [rule],
|
||||
});
|
||||
await visitor.visit(ctx, {});
|
||||
|
||||
mockRule.verify();
|
||||
expect(ctx.errors.length).to.equal(0);
|
||||
});
|
||||
|
||||
itLeaks('should call visit for each selected item', async () => {
|
||||
const ctx = new VisitorContext({
|
||||
logger: NullLogger.global,
|
||||
schemaOptions: {
|
||||
coerce: false,
|
||||
defaults: false,
|
||||
mutate: false,
|
||||
},
|
||||
});
|
||||
const data = {};
|
||||
const rule = new SchemaRule({
|
||||
check: {},
|
||||
desc: '',
|
||||
level: LogLevel.Info,
|
||||
name: 'foo',
|
||||
select: '$',
|
||||
tags: [],
|
||||
});
|
||||
|
||||
const mockRule = mock(rule);
|
||||
|
||||
const pickStub = mockRule.expects('pick').once().withArgs(ctx, data);
|
||||
pickStub.onFirstCall().returns(Promise.resolve([data]));
|
||||
pickStub.throws();
|
||||
|
||||
const visitStub = mockRule.expects('visit').once().withArgs(ctx, data);
|
||||
visitStub.onFirstCall().returns(Promise.resolve(ctx));
|
||||
visitStub.throws();
|
||||
|
||||
const visitor = new RuleVisitor({
|
||||
rules: [rule],
|
||||
});
|
||||
await visitor.visit(ctx, {});
|
||||
|
||||
mockRule.verify();
|
||||
expect(ctx.errors.length).to.equal(0);
|
||||
});
|
||||
|
||||
itLeaks('should visit individual items', async () => {
|
||||
const ctx = new VisitorContext({
|
||||
logger: NullLogger.global,
|
||||
schemaOptions: {
|
||||
coerce: false,
|
||||
defaults: false,
|
||||
mutate: false,
|
||||
},
|
||||
});
|
||||
const data = {
|
||||
foo: [1, 2, 3],
|
||||
};
|
||||
const rule = new SchemaRule({
|
||||
check: {},
|
||||
desc: '',
|
||||
level: LogLevel.Info,
|
||||
name: 'foo',
|
||||
select: '$.foo.*',
|
||||
tags: [],
|
||||
});
|
||||
|
||||
const pickSpy = spy(rule, 'pick');
|
||||
const visitStub = stub(rule, 'visit').returns(Promise.resolve({
|
||||
changes: [],
|
||||
errors: [],
|
||||
}));
|
||||
|
||||
const visitor = new RuleVisitor({
|
||||
rules: [rule],
|
||||
});
|
||||
await visitor.visit(ctx, data);
|
||||
|
||||
expect(pickSpy).to.have.callCount(1).and.to.have.been.calledWithExactly(ctx, data);
|
||||
expect(visitStub).to.have.callCount(3);
|
||||
});
|
||||
|
||||
itLeaks('should visit individual items', async () => {
|
||||
const ctx = new VisitorContext({
|
||||
logger: NullLogger.global,
|
||||
schemaOptions: {
|
||||
coerce: false,
|
||||
defaults: false,
|
||||
mutate: false,
|
||||
},
|
||||
});
|
||||
const data = {
|
||||
foo: [1, 2, 3],
|
||||
};
|
||||
const rule = new SchemaRule({
|
||||
check: {},
|
||||
desc: '',
|
||||
level: LogLevel.Info,
|
||||
name: 'foo',
|
||||
select: '$.foo.*',
|
||||
tags: [],
|
||||
});
|
||||
|
||||
const visitStub = stub(rule, 'visit').returns(Promise.resolve({
|
||||
changes: [],
|
||||
errors: [{
|
||||
data: {},
|
||||
level: LogLevel.Error,
|
||||
msg: 'kaboom!',
|
||||
}],
|
||||
}));
|
||||
|
||||
const visitor = new RuleVisitor({
|
||||
rules: [rule],
|
||||
});
|
||||
await visitor.visit(ctx, data);
|
||||
|
||||
expect(visitStub).to.have.callCount(3);
|
||||
expect(ctx.errors.length).to.equal(3);
|
||||
});
|
||||
|
||||
itLeaks('should not pick items', async () => {
|
||||
const ctx = new VisitorContext({
|
||||
logger: NullLogger.global,
|
||||
schemaOptions: {
|
||||
coerce: false,
|
||||
defaults: false,
|
||||
mutate: false,
|
||||
},
|
||||
});
|
||||
const visitor = new RuleVisitor({
|
||||
rules: [],
|
||||
});
|
||||
|
||||
return expect(visitor.pick(ctx, {})).to.eventually.deep.equal([]);
|
||||
});
|
||||
});
|
||||
|
||||
describe('create rule sources helper', () => {
|
||||
it('should ensure every field is an array', () => {
|
||||
const sources = createRuleSources({});
|
||||
|
|
|
|||
|
|
@ -0,0 +1,174 @@
|
|||
import { expect } from 'chai';
|
||||
import { LogLevel, NullLogger } from 'noicejs';
|
||||
import { mock, spy, stub } from 'sinon';
|
||||
|
||||
import { RuleVisitor } from '../../src/rule/RuleVisitor';
|
||||
import { SchemaRule } from '../../src/rule/SchemaRule';
|
||||
import { VisitorContext } from '../../src/visitor/VisitorContext';
|
||||
import { describeLeaks, itLeaks } from '../helpers/async';
|
||||
|
||||
describeLeaks('rule visitor', async () => {
|
||||
itLeaks('should only call visit for selected items', async () => {
|
||||
const ctx = new VisitorContext({
|
||||
logger: NullLogger.global,
|
||||
schemaOptions: {
|
||||
coerce: false,
|
||||
defaults: false,
|
||||
mutate: false,
|
||||
},
|
||||
});
|
||||
const data = {};
|
||||
const rule = new SchemaRule({
|
||||
check: {},
|
||||
desc: '',
|
||||
level: LogLevel.Info,
|
||||
name: 'foo',
|
||||
select: '$',
|
||||
tags: [],
|
||||
});
|
||||
|
||||
const mockRule = mock(rule);
|
||||
mockRule.expects('visit').never();
|
||||
|
||||
const pickStub = mockRule.expects('pick').once().withArgs(ctx, data);
|
||||
pickStub.onFirstCall().returns(Promise.resolve([]));
|
||||
pickStub.throws();
|
||||
|
||||
const visitor = new RuleVisitor({
|
||||
rules: [rule],
|
||||
});
|
||||
await visitor.visit(ctx, {});
|
||||
|
||||
mockRule.verify();
|
||||
expect(ctx.errors.length).to.equal(0);
|
||||
});
|
||||
|
||||
itLeaks('should call visit for each selected item', async () => {
|
||||
const ctx = new VisitorContext({
|
||||
logger: NullLogger.global,
|
||||
schemaOptions: {
|
||||
coerce: false,
|
||||
defaults: false,
|
||||
mutate: false,
|
||||
},
|
||||
});
|
||||
const data = {};
|
||||
const rule = new SchemaRule({
|
||||
check: {},
|
||||
desc: '',
|
||||
level: LogLevel.Info,
|
||||
name: 'foo',
|
||||
select: '$',
|
||||
tags: [],
|
||||
});
|
||||
|
||||
const mockRule = mock(rule);
|
||||
|
||||
const pickStub = mockRule.expects('pick').once().withArgs(ctx, data);
|
||||
pickStub.onFirstCall().returns(Promise.resolve([data]));
|
||||
pickStub.throws();
|
||||
|
||||
const visitStub = mockRule.expects('visit').once().withArgs(ctx, data);
|
||||
visitStub.onFirstCall().returns(Promise.resolve(ctx));
|
||||
visitStub.throws();
|
||||
|
||||
const visitor = new RuleVisitor({
|
||||
rules: [rule],
|
||||
});
|
||||
await visitor.visit(ctx, {});
|
||||
|
||||
mockRule.verify();
|
||||
expect(ctx.errors.length).to.equal(0);
|
||||
});
|
||||
|
||||
itLeaks('should visit individual items', async () => {
|
||||
const ctx = new VisitorContext({
|
||||
logger: NullLogger.global,
|
||||
schemaOptions: {
|
||||
coerce: false,
|
||||
defaults: false,
|
||||
mutate: false,
|
||||
},
|
||||
});
|
||||
const data = {
|
||||
foo: [1, 2, 3],
|
||||
};
|
||||
const rule = new SchemaRule({
|
||||
check: {},
|
||||
desc: '',
|
||||
level: LogLevel.Info,
|
||||
name: 'foo',
|
||||
select: '$.foo.*',
|
||||
tags: [],
|
||||
});
|
||||
|
||||
const pickSpy = spy(rule, 'pick');
|
||||
const visitStub = stub(rule, 'visit').returns(Promise.resolve({
|
||||
changes: [],
|
||||
errors: [],
|
||||
}));
|
||||
|
||||
const visitor = new RuleVisitor({
|
||||
rules: [rule],
|
||||
});
|
||||
await visitor.visit(ctx, data);
|
||||
|
||||
expect(pickSpy).to.have.callCount(1).and.to.have.been.calledWithExactly(ctx, data);
|
||||
expect(visitStub).to.have.callCount(3);
|
||||
});
|
||||
|
||||
itLeaks('should visit individual items', async () => {
|
||||
const ctx = new VisitorContext({
|
||||
logger: NullLogger.global,
|
||||
schemaOptions: {
|
||||
coerce: false,
|
||||
defaults: false,
|
||||
mutate: false,
|
||||
},
|
||||
});
|
||||
const data = {
|
||||
foo: [1, 2, 3],
|
||||
};
|
||||
const rule = new SchemaRule({
|
||||
check: {},
|
||||
desc: '',
|
||||
level: LogLevel.Info,
|
||||
name: 'foo',
|
||||
select: '$.foo.*',
|
||||
tags: [],
|
||||
});
|
||||
|
||||
const visitStub = stub(rule, 'visit').returns(Promise.resolve({
|
||||
changes: [],
|
||||
errors: [{
|
||||
data: {},
|
||||
level: LogLevel.Error,
|
||||
msg: 'kaboom!',
|
||||
}],
|
||||
}));
|
||||
|
||||
const visitor = new RuleVisitor({
|
||||
rules: [rule],
|
||||
});
|
||||
await visitor.visit(ctx, data);
|
||||
|
||||
expect(visitStub).to.have.callCount(3);
|
||||
expect(ctx.errors.length).to.equal(3);
|
||||
});
|
||||
|
||||
itLeaks('should not pick items', async () => {
|
||||
const ctx = new VisitorContext({
|
||||
logger: NullLogger.global,
|
||||
schemaOptions: {
|
||||
coerce: false,
|
||||
defaults: false,
|
||||
mutate: false,
|
||||
},
|
||||
});
|
||||
const visitor = new RuleVisitor({
|
||||
rules: [],
|
||||
});
|
||||
|
||||
return expect(visitor.pick(ctx, {})).to.eventually.deep.equal([]);
|
||||
});
|
||||
});
|
||||
Loading…
Reference in New Issue