diff --git a/config/rollup.js b/config/rollup.js index f966698..207eea6 100644 --- a/config/rollup.js +++ b/config/rollup.js @@ -76,6 +76,7 @@ const bundle = { ], 'node_modules/noicejs/out/main-bundle.js': [ 'BaseError', + 'ConsoleLogger', ], 'node_modules/js-yaml/index.js': [ 'DEFAULT_SAFE_SCHEMA', diff --git a/test/TestRule.ts b/test/TestRule.ts index fac2a78..1a39e18 100644 --- a/test/TestRule.ts +++ b/test/TestRule.ts @@ -1,5 +1,9 @@ import { expect } from 'chai'; -import { Rule, resolveRules, makeSelector } from 'src/rule'; +import { ConsoleLogger } from 'noicejs'; +import { mock } from 'sinon'; + +import { makeSelector, resolveRules, Rule, visitRules } from 'src/rule'; +import { VisitorContext } from 'src/visitor/context'; const TEST_RULES = [new Rule({ name: 'foo', @@ -94,3 +98,67 @@ describe('rule resolver', () => { }); }); }); + +describe('rule visitor', () => { + it('should only call visit for selected items', async () => { + const ctx = new VisitorContext({ + coerce: false, + defaults: false, + logger: new ConsoleLogger(), + }); + const data = {}; + const rule = new Rule({ + name: 'foo', + desc: '', + level: 'info', + tags: [], + select: '$', + check: {}, + }); + + const mockRule = mock(rule); + mockRule.expects('visit').never(); + + const pickStub = mockRule.expects('pick').once().withArgs(ctx, data); + pickStub.onFirstCall().returns(Promise.resolve([])); + pickStub.throws(); + + await visitRules(ctx, [rule], {}); + + mockRule.verify(); + expect(ctx.errors.length).to.equal(0); + }); + + it('should call visit for each selected item', async () => { + const ctx = new VisitorContext({ + coerce: false, + defaults: false, + logger: new ConsoleLogger(), + }); + const data = {}; + const rule = new Rule({ + name: 'foo', + desc: '', + level: 'info', + tags: [], + select: '$', + check: {}, + }); + + const mockRule = mock(rule); + + const pickStub = mockRule.expects('pick').once().withArgs(ctx, data); + pickStub.onFirstCall().returns(Promise.resolve([data])); + pickStub.throws(); + + const visitStub = mockRule.expects('visit').once().withArgs(ctx, data); + visitStub.onFirstCall().returns(Promise.resolve(ctx)); + visitStub.throws(); + + await visitRules(ctx, [rule], {}); + + mockRule.verify(); + expect(ctx.errors.length).to.equal(0); + }) + +}); \ No newline at end of file