lint: extract visit item method

src/rule/RuleVisitor.ts

@@ -20,7 +20,7 @@ export class RuleVisitor implements RuleVisitorOptions, Visitor {
   }
 
   public async pick(ctx: VisitorContext, root: any): Promise<Array<any>> {
-    return []; // why is this part of visitor rather than rule?
+    return []; // TODO: why is this part of visitor rather than rule?
   }
 
   public async visit(ctx: VisitorContext, root: any): Promise<VisitorContext> {
@@ -32,13 +32,23 @@ export class RuleVisitor implements RuleVisitorOptions, Visitor {
           itemIndex,
           rule,
         };
+
+        await this.visitItem(ctx, item, itemIndex, rule);
+        itemIndex += 1;
+      }
+    }
+
+    return ctx;
+  }
+
+  public async visitItem(ctx: VisitorContext, item: any, itemIndex: number, rule: Rule): Promise<void> {
     const itemResult = cloneDeep(item);
     const ruleResult = await rule.visit(ctx, itemResult);
 
     if (hasItems(ruleResult.errors)) {
       ctx.logger.warn({ count: ruleResult.errors.length, rule }, 'rule failed');
       ctx.mergeResult(ruleResult, ctx.visitData);
-          continue;
+      return;
     }
 
     const itemDiff = diff(item, itemResult);
@@ -55,11 +65,5 @@ export class RuleVisitor implements RuleVisitorOptions, Visitor {
     } else {
       ctx.logger.info({ rule: rule.name }, 'rule passed');
     }
-
-        itemIndex += 1;
-      }
-    }
-
-    return ctx;
   }
 }

test/TestApp.ts

@@ -81,4 +81,6 @@ describeLeaks('main app', async () => {
 
     expect(status).to.equal(STATUS_ERROR);
   });
+
+  it('should fix up partial documents'); // TODO: test fix mode
 });